build(deps): bump got from 13.0.0 to 14.0.0 in /docs #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [got](https://github.com/sindresorhus/got) from 13.0.0 to 14.0.0. - [Release notes](https://github.com/sindresorhus/got/releases) - [Commits](sindresorhus/got@v13.0.0...v14.0.0) --- updated-dependencies: - dependency-name: got dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #75 +/- ##
=======================================
Coverage 87.20% 87.20%
=======================================
Files 32 32
Lines 2603 2603
=======================================
Hits 2270 2270
Misses 269 269
Partials 64 64 ☔ View full report in Codecov by Sentry. |
r-hang
approved these changes
Dec 6, 2023
r-hang
added a commit
that referenced
this pull request
Dec 6, 2023
) This reverts commit 9ad160e. Post merge CI fails, with ``` yarn install v1.22.21 [1/4] Resolving packages... [2/4] Fetching packages... warning [email protected]: Invalid bin field for "url-loader". error [email protected]: The engine "node" is incompatible with this module. Expected version ">=20". Got "1[6](https://github.com/uber-go/cff/actions/runs/7118151076/job/19380501646#step:4:7).20.2" error Found incompatible module. info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command. Error: Process completed with exit code 1. ``` reverting.
JacobOaks
added a commit
that referenced
this pull request
Dec 11, 2023
We have to revert #75 because got 14.0.0 requires node 20. This diff updates to node 20 for the docs github workflow. It also re-upgrade got to 14.0.0.
JacobOaks
added a commit
that referenced
this pull request
Dec 11, 2023
We have to revert #75 because got 14.0.0 requires node 20. This diff updates to node 20 for the docs github workflow. It also re-upgrade got to 14.0.0.
JacobOaks
added a commit
that referenced
this pull request
Dec 11, 2023
We have to revert #75 because got 14.0.0 requires node 20. This diff updates to node 20 for the docs github workflow. It also re-upgrade got to 14.0.0.
JacobOaks
added a commit
to JacobOaks/cff
that referenced
this pull request
Dec 11, 2023
We have to revert uber-go#75 because got 14.0.0 requires node 20. This diff updates to node 20 for the docs github workflow. It also re-upgrade got to 14.0.0. Initially, this causes another issue when building the docs: ``` tip Apply plugin mermaidjs (i.e. "vuepress-plugin-mermaidjs") ... [info] [webpackbar] Compiling Client [info] [webpackbar] Compiling Server /home/runner/work/cff/cff/docs/node_modules/loader-runner/lib/LoaderRunner.js:114 throw e; ^ Error: error:0308010C:digital envelope routines::unsupported at new Hash (node:internal/crypto/hash:68:19) at Object.createHash (node:crypto:138:10) at module.exports (/home/runner/work/cff/cff/docs/node_modules/webpack/lib/util/createHash.js:135:53) at NormalModule._initBuildHash (/home/runner/work/cff/cff/docs/node_modules/webpack/lib/NormalModule.js:417:16) at handleParseError (/home/runner/work/cff/cff/docs/node_modules/webpack/lib/NormalModule.js:471:10) at /home/runner/work/cff/cff/docs/node_modules/webpack/lib/NormalModule.js:503:5 at /home/runner/work/cff/cff/docs/node_modules/webpack/lib/NormalModule.js:358:12 at /home/runner/work/cff/cff/docs/node_modules/loader-runner/lib/LoaderRunner.js:373:3 at iterateNormalLoaders (/home/runner/work/cff/cff/docs/node_modules/loader-runner/lib/LoaderRunner.js:214:10) at iterateNormalLoaders (/home/runner/work/cff/cff/docs/node_modules/loader-runner/lib/LoaderRunner.js:221:10) at /home/runner/work/cff/cff/docs/node_modules/loader-runner/lib/LoaderRunner.js:236:3 at context.callback (/home/runner/work/cff/cff/docs/node_modules/loader-runner/lib/LoaderRunner.js:111:13) at /home/runner/work/cff/cff/docs/node_modules/cache-loader/dist/index.js:134:7 at /home/runner/work/cff/cff/docs/node_modules/graceful-fs/graceful-fs.js:61:14 at FSReqCallback.oncomplete (node:fs:189:23) { opensslErrorStack: [ 'error:03000086:digital envelope routines::initialization error' ], library: 'digital envelope routines', reason: 'unsupported', code: 'ERR_OSSL_EVP_UNSUPPORTED' } ``` This is apparently a known issue with Node >16. Refs: * https://stackoverflow.com/questions/69692842/error-message-error0308010cdigital-envelope-routinesunsupported * vuejs/vuepress#3136 We can workaround this issue by setting `NODE_OPTIONS=--openssl-legacy-provider` when building the docs, which this PR also does. I tested the docs workflow using this branch and the env var set, and it completed successfully: https://github.com/uber-go/cff/actions/runs/7172095319
r-hang
pushed a commit
that referenced
this pull request
Jan 6, 2024
…79) We had to revert #75 because got 14.0.0 requires node 20. This PR updates to node 20 for the docs github workflow. It also re-upgrade got to 14.0.0. This caused another issue when building the docs: ``` tip Apply plugin mermaidjs (i.e. "vuepress-plugin-mermaidjs") ... [info] [webpackbar] Compiling Client [info] [webpackbar] Compiling Server /home/runner/work/cff/cff/docs/node_modules/loader-runner/lib/LoaderRunner.js:114 throw e; ^ Error: error:0308010C:digital envelope routines::unsupported at new Hash (node:internal/crypto/hash:68:19) at Object.createHash (node:crypto:138:10) at module.exports (/home/runner/work/cff/cff/docs/node_modules/webpack/lib/util/createHash.js:135:53) at NormalModule._initBuildHash (/home/runner/work/cff/cff/docs/node_modules/webpack/lib/NormalModule.js:417:16) at handleParseError (/home/runner/work/cff/cff/docs/node_modules/webpack/lib/NormalModule.js:471:10) at /home/runner/work/cff/cff/docs/node_modules/webpack/lib/NormalModule.js:503:5 at /home/runner/work/cff/cff/docs/node_modules/webpack/lib/NormalModule.js:358:12 at /home/runner/work/cff/cff/docs/node_modules/loader-runner/lib/LoaderRunner.js:373:3 at iterateNormalLoaders (/home/runner/work/cff/cff/docs/node_modules/loader-runner/lib/LoaderRunner.js:214:10) at iterateNormalLoaders (/home/runner/work/cff/cff/docs/node_modules/loader-runner/lib/LoaderRunner.js:221:10) at /home/runner/work/cff/cff/docs/node_modules/loader-runner/lib/LoaderRunner.js:236:3 at context.callback (/home/runner/work/cff/cff/docs/node_modules/loader-runner/lib/LoaderRunner.js:111:13) at /home/runner/work/cff/cff/docs/node_modules/cache-loader/dist/index.js:134:7 at /home/runner/work/cff/cff/docs/node_modules/graceful-fs/graceful-fs.js:61:14 at FSReqCallback.oncomplete (node:fs:189:23) { opensslErrorStack: [ 'error:03000086:digital envelope routines::initialization error' ], library: 'digital envelope routines', reason: 'unsupported', code: 'ERR_OSSL_EVP_UNSUPPORTED' } ``` This is apparently a known issue with Node 17.0.0+, which upgrades Node to OpenSSL 3.0. This new version disallows certain legacy operations found to be vulnerable to security attacks. * https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V17.md#17.0.0 * vuejs/vuepress#3136 We can workaround this issue by setting `NODE_OPTIONS=--openssl-legacy-provider` when building the docs, which this PR also does. This is not an ideal solution as using the older OpenSSL version. The issue is resolved by upgrading the other dependencies in our yarn.lock. --------- Co-authored-by: Abhinav Gupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps got from 13.0.0 to 14.0.0.
Release notes
Sourced from got's releases.
Commits
382241214.0.08197422Readme tweaksa004263Require Node.js 20 (#2313)7c3f147MakefollowRedirectoption accept a function (#2306)844cfb6Add note about retry in timeout documentation (#2298)944caa8TweaksDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)